Hi Yujun,
The issues are fixed now and the job gets triggered correctly by the keyword
check-experimental.
If the values are not passed to the macros, they will not be updated by jjb and
stay as they are - {project} and {branch}.
We verify jjb updates using jjb but this type of errors are not caught by it.
/Fatih
From: Yujun Zhang <[email protected]>
Date: Friday, 6 January 2017 at 12:46
To: Fatih Degirmenci <[email protected]>,
"[email protected]" <[email protected]>
Subject: Re: [opnfv-tech-discuss] [infra][doctor] experimental trigger not
working
Thanks Fatih
Fix proposed in https://gerrit.opnfv.org/gerrit/#/c/26767/
What will the value of '{project}' be if we forget to pass a variable to the
macro? Is it possible to detect such error with a verification job?
On Fri, Jan 6, 2017 at 7:15 PM Fatih Degirmenci
<[email protected]<mailto:[email protected]>> wrote:
Hi Yujun,
This is due to not passing project and branch values to macro. This causes the
use of incorrect values for PROJECT and GERRIT_PROJECT parameters in the
created Jenkins job. (job has {project} as PROJECT value and {branch} as
GERRIT_PROJECT value as oppose to doctor and master respectively.)
You either need to pass those values
triggers:
- 'doctor-experimental':
project: '{project}'
branch: '{branch}'
or move trigger into job body rather than using macro.
/Fatih
From:
<[email protected]<mailto:[email protected]>>
on behalf of Yujun Zhang
<[email protected]<mailto:zhangyujun%[email protected]>>
Date: Friday, 6 January 2017 at 08:02
To:
"[email protected]<mailto:[email protected]>"
<[email protected]<mailto:[email protected]>>
Subject: [opnfv-tech-discuss] [infra][doctor] experimental trigger not working
Hi, infra experts
We want to introduce a jenkins job trigger for experimental changes[1]
A trigger is created for doctor project[2], but it seems not working as
expected. When a new comment "check experimental" is added[3], no job is
triggered[4] as expected.
Could anyone give some hint on how to debug such issue?
The trigger is defined as a macro and referenced in doctor-profiling-master job
- trigger:
name: 'doctor-experimental'
triggers:
- gerrit:
server-name: 'gerrit.opnfv.org<http://gerrit.opnfv.org>'
trigger-on:
- comment-added-contains-event:
comment-contains-value: 'check experimental'
- job-template:
name: 'doctor-profiling-{stream}'
...
triggers:
- 'doctor-experimental'
[1]: http://docs.openstack.org/infra/system-config/test-infra-
requirements.html#experimental<http://docs.openstack.org/infra/system-config/test-infra-requirements.html#experimental>
[2]:https://gerrit.opnfv.org/gerrit/#/c/26439/
[3]: https://gerrit.opnfv.org/gerrit/#/c/26531/
[4]: https://build.opnfv.org/ci/view/doctor/job/doctor-profiling-master/
_______________________________________________
opnfv-tech-discuss mailing list
[email protected]
https://lists.opnfv.org/mailman/listinfo/opnfv-tech-discuss
