On 9.05.2023 18:21, Felix Baumann wrote:
Am 9. Mai 2023 15:29:48 MESZ schrieb "Rafał Miłecki" <zaj...@gmail.com>:
From: Rafał Miłecki <ra...@milecki.pl>

There is no need to use reference if original node it specified in
exactly the same file. This is a minor cleanup simplifying DTS code.

Signed-off-by: Rafał Miłecki <ra...@milecki.pl>
---
.../linux/ramips/dts/mt7621_netgear_r6220.dts  | 18 ++++++++----------
1 file changed, 8 insertions(+), 10 deletions(-)

diff --git a/target/linux/ramips/dts/mt7621_netgear_r6220.dts 
b/target/linux/ramips/dts/mt7621_netgear_r6220.dts
index 0f476ef060..7bb49c15b4 100644
--- a/target/linux/ramips/dts/mt7621_netgear_r6220.dts
+++ b/target/linux/ramips/dts/mt7621_netgear_r6220.dts
@@ -42,9 +42,17 @@
                };

                factory: partition@2e00000 {

The "factory" reference could be probably be dropped as well. Proposed changes 
look good to me.

Actually it can't be dropped. While it's a bit counter-intuitive, that
label is used in a *parent* DTS file mt7621_netgear_sercomm_ayx.dtsi .


+                       compatible = "nvmem-cells";
                        label = "factory";
                        reg = <0x2e00000 0x100000>;
                        read-only;
+
+                       #address-cells = <1>;
+                       #size-cells = <1>;
+
+                       macaddr_factory_4: macaddr@4 {
+                               reg = <0x4 0x6>;
+                       };
                };

                partition@4200000 {
@@ -65,13 +73,3 @@
        nvmem-cell-names = "mac-address";
        mac-address-increment = <1>;
};
-
-&factory {
-       compatible = "nvmem-cells";
-       #address-cells = <1>;
-       #size-cells = <1>;
-
-       macaddr_factory_4: macaddr@4 {
-               reg = <0x4 0x6>;
-       };
-};
--
2.35.3

_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to