On 2020-07-15 09:56, Jo-Philipp Wich wrote: > Hi, > >> Changes: >> - The device is created as a netifd bridge >> - Bridge vlan sections should always refer to the bridge instead of >> automatically be applied to the first one >> - Use = instead of . to mark tagging modifiers. "." is already used >> for vlan interface names and reusing it here creates ambiguity. >> - Allow specifing pvid as a modifier instead of needing to create a >> separate port section. >> >> The section names are optional, I chose to put them in to make it easier >> to modify the sections from scripts >> >> What do you think? > > First of all, I was reworking dsaconfig into a very similar direction for a v3 > so overall I do like your proposal and I think it makes sense. > > Specific points from my side: > > - I dislike the equal sign syntax, colon would fit better imho I didn't pick it, because it is already used for linux alias netdevices. Since we don't use those, I guess it might not be a problem in practice.
> - For denoting pvid I used a trailing asterisk, like the old roboswitch config Fine with me as well. > - The bridge-vlan sections should be anonymous Sure. As I pointed out, the section name should be optional. > - Bridge vlan filtering will be implicitely enabled as soon as at least one > bridge-vlan section references a bridge device? Yes. I just discussed with John that I'm going to start working on a netifd prototype implementation this week, and I'll include your proposed modifications. - Felix _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
