Re: [OpenWrt-Devel] [PATCH v2 3/5] ath79: add support for Netgear WNR2000 v3

[Adrian Schmutzler]

Hi,

> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] On 
> Behalf Of Michal Cieslakiewicz
> Sent: Dienstag, 6. August 2019 16:04
> To: openwrt-devel@lists.openwrt.org
> Cc: Adrian Schmutzler <m...@adrianschmutzler.de>
> Subject: [OpenWrt-Devel] [PATCH v2 3/5] ath79: add support for Netgear 
> WNR2000 v3
> 
> This patch adds ath79 support for Netgear WNR2000v3.
> Router was previously supported by ar71xx target only.
> Note: this is a 4_32 device with limited upgrade capabilities.
> 
...

> 
> diff --git a/target/linux/ath79/base-files/etc/board.d/01_leds 
> b/target/linux/ath79/base-files/etc/board.d/01_leds
> index 29c32ada72..f083ab9ea2 100755
> --- a/target/linux/ath79/base-files/etc/board.d/01_leds
> +++ b/target/linux/ath79/base-files/etc/board.d/01_leds
> @@ -93,6 +93,19 @@ glinet,gl-ar300m-lite)
>  glinet,gl-x750)
>       ucidef_set_led_netdev "wan" "WAN" "$boardname:green:wan" "eth1"
>       ;;
> +netgear,wnr2000-v3)
> +     ucidef_set_led_netdev "wan-amber" "WAN (amber)" "netgear:amber:wan" 
> "eth0"
> +     ucidef_set_led_default "wan-green" "WAN (green)" "netgear:green:wan" "0"
> +     ucidef_set_led_wlan "wlan" "WLAN" "netgear:blue:wlan" "phy0tpt"

Don't think you need this if trigger is defined in DTS?

...

> +
> +&eth0 {
> +     status = "okay";
> +
> +     mtd-mac-address = <&art 0x00>;

Maybe just use 0x0 here instead of 0x00, also for subsequent cases ...

...

> +
> +define Device/netgear_wnr2000-v3
> +  ATH_SOC := ar7241
> +  DEVICE_VENDOR := Netgear

Device_vendor is inherited from netgear_ath79, remove it here.

> +  DEVICE_MODEL := WNR2000
> +  DEVICE_VARIANT := v3
> +  DEVICE_DTS := ar7241_netgear_wnr2000-v3

DEVICE_DTS can be removed, it is calculated automatically.

> +  NETGEAR_KERNEL_MAGIC := 0x32303033
> +  NETGEAR_BOARD_ID := WNR2000V3
> +  NETGEAR_HW_ID := 29763551+04+32
> +  IMAGE_SIZE := 3712k
> +  IMAGE/default := append-kernel | pad-to $$$$(BLOCKSIZE) | netgear-squashfs 
> | append-rootfs | pad-rootfs
> +  IMAGES += factory-NA.img
> +  IMAGE/factory-NA.img := $$(IMAGE/default) | netgear-dni NA | check-size 
> $$$$(IMAGE_SIZE)
> +  SUPPORTED_DEVICES += wnr2000-v3
> +  $(Device/netgear_ath79)
> +endef
> +TARGET_DEVICES += netgear_wnr2000-v3

You may also adjust the subsequent device support PRs accordingly.

Best

Adrian

openpgp-digital-signature.asc
Description: PGP signature

_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel