вт, 26 февр. 2019 г. в 16:03, Adrian Schmutzler <m...@adrianschmutzler.de>: > > > -----Original Message----- > > From: Dmitry Tunin [mailto:hanipouspi...@gmail.com] > > Sent: Dienstag, 26. Februar 2019 10:45 > > To: Adrian Schmutzler <m...@adrianschmutzler.de> > > Subject: Re: [OpenWrt-Devel] [PATCH] ath79: speed up ath9k-eeprom > > extraction > > > > вт, 26 февр. 2019 г. в 02:13, <m...@adrianschmutzler.de>: > > > > > > Hi Dmitry, > > > > > > I just sent a bunch of patches based on your initial patch. > > > > > > Note that your patch is only stored as comment to another and lacks > > > Signed- > > off, if I'm not mistaken. > > That wasn't my patch. It was a comment to my initial patch as an > > opinion how to do it better. > > > > Ah, now I finally get it. > Sorry for the noise. > > So, since you were first and your real initial patch is tested, I suppose it > should be applied. > > Despite that, some feedback about whether the merging in eeprom.sh is an > accepted way to go would be helpful. > > If no, I would rebase my first patchset (changing dd in-place) on Dmitry's > real patch. > > If yes, either Petr Štetiar can resend his patch proposal or allow me to > "take it over", and I go on with my second patchset (moving all to eeprom.sh). > > What will it be? >
My opinion is that I have no opinion really. It's important to speedup that process, but everything else is very minor. Using eeprom.sh needs a bit of testing on many platforms, but I am already 99.9% sure it'll work OK. The other part with changing dd's that patch mac addresses can be or not. I don't really care, because it is catching fractions of seconds. It looks OK for me too. Petr posted his variant to me most likely with intention that I or someone else takes care of it properly. So it would be very good if you finish the job the way you like. If it can be properly tested on every target would be great. _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
