The generic changes I had intended to remove before a final submission. I'm also wondering what the best way to handle devices with 1 ethernet port is, should that be a WAN or a LAN port(right now it seems to be WAN with some things on the firewall opened up), it also has a rarely used wireless header that is configured as a LAN port. For the moment I'm a little stuck on separating it out fully from the tp-link device specifically in relation to tplink_board_detect() and the conflicting ID, would you have any suggestions for how to fix that? I'll work on making the patch as small as possible as well. I created the patch using a git diff and it seemed to apply when I used git apply, did my mail client mess up the formatting?
On Sun, May 10, 2015 at 5:23 AM, Felix Fietkau <n...@openwrt.org> wrote: > On 2015-05-02 05:08, James Hilliard wrote: >> I did my best to separate this device out, below is my current patch, >> comments appreciated. I'm having trouble figuring out how to >> differentiate the hwid which seems to be the same as the tp-link >> wr743nd-v2. 0x07430002 Is the hardware ID that both seem to have, is >> there any other ID's that I may be able to use? >> > There are a lot of seemingly bogus unrelated changes, especially the > ones to the generic code. The patch is completely misformatted, so it > won't ever apply. > Many of the changes do not make sense, so please make an effort to > reduce the patch to the smallest amount of change to support the platform. > > - Felix _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
