On 04/04/14 07:49, Matthew Fatheree wrote:
our intention was to get this process started,
so we could address any issues as soon as possible.
Hi Matthew,
Non-dev here. Just a couple of comments. Mainly that I recommend in
future your team should follow patch submission style guide.
https://dev.openwrt.org/wiki/SubmittingPatches
This will aid others in identifying the submission, as well as accepting
and documenting patches that are accepted.
Personally, I missed this submission as it:
1. Subject did not contain SUMMARY with a globally-unique identifier for
that patch (eg, 'WRT1900AC initial submission')
2. Was not signed
3. Did not contain diffs but contained an external link to patches
(admittedly, given the binary blob submission and the 'NO MIME' rule for
patches this may have been a little tricky for you at such an early
stage, however the text sections could've been submitted and just the
blob left on your FTP server... at a stretch... although personally I
don't like that either see other's comments about blob "submissions"...)
I look forward to seeing more submissions from Belkin and hope they can
conform to the standard expected by OpenWRT hackers.
Cheers,
Pete.
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
