Hi Hauke, Thank you for your comments. I will notify the development team about the issues you have identified with the fan control driver, and wireless driver.
Our goal was to start this submission process early to identify any issues. Thank you again for your help Matt On Thu, 2014-04-03 at 21:26 +0200, Hauke Mehrtens wrote: > On 04/03/2014 07:52 PM, Matthew Fatheree wrote: > > Belkin Inc. would like to announce the patch submission release for > > WRT1900AC > > which is based on OpenWRT trunk, the detail base revision is specified in > > each release. > > > > This is the release version 1.1 of WRT1900AC Openwrt patch submission > > OpenWRT git base revision: e97be7a104e5c809ae4638cf169823249a505698 > > OpenWRT svn base revision: 40006 > > > > The total size of the uncompressed files exceeds the 300k maximum for email > > attachments. > > The patch files can be accessed using the link below: > > > > Direct Link: ftp://Temp90523934364:tag43...@ftp.belkin.com/Temp90523934364 > > > > Thank you > > > > Matthew Fatheree > > I have some comments on the patches. > > Your fan_ctrl.c driver has a very strange architecture. You should not > call a user space application from kernel space and then you should not > access registers from a shell script. You should probably put the > functionality you currently have in the shell script into the kernel > driver and the stuff from the kernel driver into the shell script. Or > put every thing into a kernel driver. > > Adding a binary kernel module into OpenWrt like you did with ap8x.ko > module will not work, because it depends on one exact kernel version and > config. When the offset of one member in e.g. skbuff changes in the > kernel because I change a kernel option your module will come up with > strange runtime errors. You should provide the source code of the > wireless driver and build it with the OpenWrt build system. > > This looks like a version of the driver you are suing licensed under the > terms of the GPL: > https://github.com/kmihelich/wlan-smileplug > > I haven't done a full review of your patches. > > Hauke __________________________________________________________________ Confidential This e-mail and any files transmitted with it are the property of Belkin International, Inc. and/or its affiliates, are confidential, and are intended solely for the use of the individual or entity to whom this e-mail is addressed. If you are not one of the named recipients or otherwise have reason to believe that you have received this e-mail in error, please notify the sender and delete this message immediately from your computer. Any other use, retention, dissemination, forwarding, printing or copying of this e-mail is strictly prohibited. Pour la version française: http://www.belkin.com/email-notice/French.html Für die deutsche Übersetzung: http://www.belkin.com/email-notice/German.html __________________________________________________________________ _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
