Hi Lars,

Le 22/02/2014 04:21, Lars Bøgild Thomsen a écrit :
> Hi Michel, 
> 
> On Friday 21 February 2014 22:26:42 Michel Stempin wrote:
> 
>> Just one remark concerning your proposed patch: don't define every single 
>> GPIO as a LED, this is a terrible thing to do, as it prevents you from using 
>> a given GPIO as an input without recompiling the kernel.
> 
> I have attached a new attempt (also on 
> http://github.com/ThingMesh/openwrt.git branch oolite)- better? :)
> 
> //Lars...
Yes, but you should remove the definitions for all those GPIO pins, as they ar 
eno longer required.

And I don't know if the "ath79_gpio_function_disable()" call is required or 
not, as this controls whether GPIO13-17 are used as user GPIOs or Ethernet 
switch LEDs.

-- 
Michel
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Reply via email to