Hi Lars,

Le 21/02/2014 05:38, Lars Bøgild Thomsen a écrit :
> Hi, 
> 
> First of all my apologies if I don't follow the correct procedure to the 
> letter, but this is my first attempt at feeding changes into OpenWrt.

Thank you for your time and efforts!

> 
> I have added support for the Oolite V1.0 AR9331 module.

The Gainstrong Oolite V1.0 module is just a renamed EasyLink (ELink) EL-M150: 
<http://huangfc.taobao.com/>.

This can be guessed (at least on my GS-Oolite module) by looking at the U-Boot 
banner that lists the above URL;)

This module is fully compatible with the TP-Link TL-WR710N router, including 
the switch, GPIO and LED definitions, the only difference being in the firmware 
magic number. This is not a surprise, as both are based on the same Atheros 
AP-121 reference design!

The main drawback of these modules is that they are not individually RF 
calibrated on the production line, resulting on poor/non conform WiFi 
performance. You can figure this out by reading the RF ART calibration 
partition on 2 random units: they will be the same, byte for byte :(

> 
> I have attached a patch to the git head as of right now.  If you prefer to 
> pull from git, I have made my changes public at:
> 
> https://github.com/ThingMesh/openwrt.git
> 
> in the branch "oolite" (master is identical with the openwrt master).
> 
> Hope this will get accepted and if I did any major screwups please do let me 
> know.
> 
> //Lars...

Just one remark concerning your proposed patch: don't define every single GPIO 
as a LED, this is a terrible thing to do, as it prevents you from using a given 
GPIO as an input without recompiling the kernel.

You should only define the real GS_OOLITE_GPIO_LED_SYSTEM LED and remove all 
the other ones, in order to enable an end-user to define it freely in userland 
using the /sys/class/gpio interface.

Not sure too if the Ethernet switch LEDs should be enabled or disabled.

-- 
Michel
_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Reply via email to