Hi all,

3 days ago I also sent a patch to fix a bug in netifd, where the uci mcast_rate 
setting is not properly used anymore.
See attched email I have sent to the list.
I am not sure if Antonios patch covers the same here ?

Greetings Thomas

This patch fixes a bug in /lib/netifd/wireless/mac80211.sh, where
the UCI setting of wireless multicast traffic (in uci: mcast_rate)
is not respected within netifd. Especially in Freifunk mesh networks
the olsr routing as effected by this, as only the lowest mcast_rate
was used, even when uci ncast_rate was set to something else.
In function mac80211_setup_adhoc() the value of mcast_rate is missing
in json_get_vars.

Signed-off-by: Thomas Huehn <tho...@net.t-labs.tu-berlin.de>
---
.../mac80211/files/lib/netifd/wireless/mac80211.sh |    2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/kernel/mac80211/files/lib/netifd/wireless/mac80211.sh 
b/package/kernel/mac80211/files/lib/netifd/wireless/mac80211.sh
index 12c256e..1896fe0 100644
--- a/package/kernel/mac80211/files/lib/netifd/wireless/mac80211.sh
+++ b/package/kernel/mac80211/files/lib/netifd/wireless/mac80211.sh
@@ -241,7 +241,7 @@ mac80211_setup_supplicant() {
}

mac80211_setup_adhoc() {
-       json_get_vars bssid ssid basic_rate key
+       json_get_vars bssid ssid basic_rate key mcast_rate

        keyspec=
        [ "$auth_type" == "wep" ] && {
-- 
1.7.9.5
________

Am 13.01.2014 um 11:41 schrieb Antonio Quartulli <anto...@meshcoding.com>:

> On 13/01/14 11:26, John Crispin wrote:
>> Hi,
>> 
>> ok, a prime example of why the description should state the bug that
>> was fixed and not leave it as a readers exercise :)
> 
> you got a point here! :)
> 
>> 
>> i will pull this patch into the tree after lunch.
>> 
> 
> 
> Thanks!
> 
> Cheers,
> 
> -- 
> Antonio Quartulli
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Reply via email to