On Mon, Dec 30, 2013 at 12:07 PM, Darija Tadin-Đurović <68da...@gmail.com>wrote:
> Yes. > My router didn't complain about it and was reachable by ssh. John will need to comment on if this is a correct fix. I don't know enough about what netdev->hw_features and netdev->vlan_features do. > > > > -- > Time is the quality of nature that keeps events from happening all at > once. Lately it doesn’t seem to be working. > —Anonymous > > * jonsm...@gmail.com <jonsm...@gmail.com> [2013-12-30 11:44:29 -0500]: > > > On Mon, Dec 30, 2013 at 11:19 AM, Darija Tadin-Đurović <68da...@gmail.com >> >wrote: >> >> Hello, >>> after a day and a half (!) offline, thanks to my laptop, I finally got >>> back to our RT5350 eth driver problem, and I have a solution that works >>> for >>> me. Jon, can you please test on your AsiaRF? >>> >>> With this patch, the TCP checksums are again correctly calculated, hence >>> the router is again fine. Tested on RT5350 / HLK-RM04. >>> Regards >>> Darki >>> >>> >> This leaves netdev->hw_features, netdev->vlan_features uninitialized >> >> >> >> >>> Signed-off-by: Darija Tadin-Đurović <68da...@gmail.com> >>> >>> --- a/drivers/net/ethernet/ralink/ralink_soc_eth.c >>> +++ b/drivers/net/ethernet/ralink/ralink_soc_eth.c >>> @@ -740,9 +740,9 @@ static int fe_probe(struct platform_devi >>> if (soc->tso) { >>> dev_info(&pdev->dev, "Enabling TSO\n"); >>> netdev->features |= NETIF_F_SG | NETIF_F_TSO | >>> NETIF_F_TSO6 | NETIF_F_IPV6_CSUM; >>> + netdev->hw_features = netdev->vlan_features = >>> netdev->features; >>> } >>> - netdev->hw_features = netdev->vlan_features = netdev->features; >>> netdev->irq = platform_get_irq(pdev, 0); >>> if (netdev->irq < 0) { >>> >>> >>> -- >>> Time is the quality of nature that keeps events from happening all at >>> once. Lately it doesn’t seem to be working. >>> —Anonymous >>> >>> * John Crispin <blo...@openwrt.org> [2013-12-28 09:18:25 +0100]: >>> >>> On 28/12/13 05:36, jonsm...@gmail.com wrote: >>> >>>> >>>> On Fri, Dec 27, 2013 at 4:16 PM, John Crispin<blo...@openwrt.org> >>>>> wrote: >>>>> >>>>> Hi >>>>>> >>>>>> i just pushed a patch that i think will fix the issue. can you please >>>>>> test >>>>>> it as i don't have access to a rt5350 board right now >>>>>> >>>>>> Didn't fix it. Still same failure. >>>>> >>>>> >>>>> ok, i'll have access to a rt5350 board on the 30th. you'll have to >>>> wait >>>> until then i am afraid >>>> >>>> John >>>> >>>> >>> >> >> -- >> Jon Smirl >> jonsm...@gmail.com >> > -- Jon Smirl jonsm...@gmail.com
_______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel