On 2 March 2013 23:51, Hauke Mehrtens <ha...@hauke-m.de> wrote: > On 03/02/2013 10:36 PM, Rafał Miłecki wrote: >> 2013/2/21 Hauke Mehrtens <ha...@hauke-m.de>: >>> On 02/21/2013 07:46 PM, Rafał Miłecki wrote: >>>> 2013/2/21 Hauke Mehrtens <ha...@hauke-m.de>: >>>>> On 02/19/2013 04:44 PM, Rafał Miłecki wrote: >>>>>> There is b53 PHY driver for Broadcom switches some may want to use one >>>>>> bcm47xx platform. We still don't use b53 as default, but let's at least >>>>>> allow switching to it. >>>>>> >>>>>> Signed-off-by: Rafał Miłecki <zaj...@gmail.com> >>>>>> --- >>>>>> As alternative we could use @!PACKAGE_kmod-switch in DEPENDS, but sure >>>>>> if it makes difference to anyone? >>>>> >>>>> Could we wait with this patch till there is a switch driver that could >>>>> be configured by swconfig? @!PACKAGE_kmod-switch will not work because >>>>> for some time we probably need both packages when not all drivers are >>>>> converted. >>>> >>>> I believe there already is a proper driver: b53. Don't I understand >>>> something? >>>> >>>> It works fine for my BCM53125 switch. >>>> >>> Yes it works with the switches, but not with the ethernet drivers these >>> switches are connected to. >> >> Hauke, >> >> Could you help me understanding that? ;) I'm not sure, what do we need >> to implement in b53 to start switching to it? I've compared b53 with >> rtl8367 and rtl8367b (just some random ones) and I can't see what can >> be missing in b53. >> > I added Jonas, he is the expert on this topic. > > In b53_mdio.c a phy driver is registered. Now the Ethernet driver has to > use this phy driver like described in Documentation/networking/phy.txt. > One driver using b53 is drivers/net/ethernet/broadcom/bcm63xx_enet.c and
Yes, using phy_devices is the requirement for b53 (or SPI), and afaik neither b44 nor bgmac expose it currently, so they need to properly use it for b53 to work (unless the switch is SPI connected). > it also got some additional patches in OpenWrt like this: > https://dev.openwrt.org/browser/trunk/target/linux/brcm63xx/patches-3.8/447-bcm63xx_enet_add_b53_support.patch This patch is only for exposing the internal, memory mapped switches of newer bcm63xx SoCs; it's not needed for any externally connected bcm53xx switches. Also afaik the internal switches of bcm47xx are available through MDIO, so there /should/ be nothing like this needed for that target. > . > > b53 should work without modifications if bgmac and the other Ethernet > drivers are using it. Exactly. Well, except for the internal switches of bcm535x/536x - I have no guarantee for them since I don't have any device using them ;). Jonas _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
