On Wed, 2012-11-28 at 06:18 -0800, Daniel Gimpelevich wrote: > On Wed, 2012-11-28 at 10:09 +0000, Conor O'Gorman wrote: > > This will affect all lantiq atm boards? I specify an ethernet MAC via > > the command line, but I don't necessarily want it in the atm. > > > The existing code leaves the MAC at all zeros. Do you require that > instead of the MAC you specify for Ethernet? The latinq ATM driver > provides no way to have it be anything other than zeros at the driver > level. None. At least on the Netgear, the stock firmware increments the > Ethernet address to get the ATM one, and it receives the Ethernet > address and no other address on the kernel command line. I will soon be > looking at the Gigaset for comparison, but I expect it likely does the > same thing. It's perfectly reasonable not to want an increment of the > supplied Ethernet address in the ATM, but that implies you have some > other MAC you'd like it to have instead. If you can reveal where this > MAC comes from and how you'd like to supply it to the driver, that would > be a first step to de-uglifying this dirty hack. It really boggles my > mind that this has never been discussed before. >
Hi Daniel, Thank you for consider my comments. There are a couple of points I'd make. AFAIK this is only needed for ethernet bridging over atm. I am not familiar with an ethernet style mac being used in straight atm connections. As far as I can see the field you are setting is only pulled out by the br2684 driver, which is providing the ethernet veneer. I do see that one or two atm drivers get a serial number from their hardware, and a few more pull up an eeprom value. Would some adjustment in br2684 be more appropriate? I have no problem with a hack, if it is recognised as such, with some intention to improve it later. Concerning what MAC to apply, yes some variation on the serial number is appropriate. I have in the past used the top bits of the available space, rather than a simple increment, as it avoids bumping into a similar unit. Conor _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
