@Karl,
    Thank you, I will try to get ahold of one of those boards.
@Hanno,
    This was intended to only fix the booting. I'll repost and include
        the gpio changes as well.

I cloned the OpenWRT git onto github where I was going to start work on the updates for the atheros targets. Once they've all been tested on various pieces of hardware i'll submit them to openwrt-devel as patch-sets. Feel free to test and submit any merge requests prior to me submitting to openwrt-devel.
https://github.com/JB1tz/openwrt-atheros

Feel free to disregard this current patch so that we can try to merge everything at once.

On 11/21/2012 06:27 PM, Karl P wrote:

It's a "dragino" http://www.dragino.com/ They're also sold by flukso: https://www.flukso.net/

It's an ar2317. AA and trunk are the same, as this leds change went into trunk before AA was pulled as a separate branch. I only first tried this board out with backfire, and the wlan led worked out of the box. I added the sysfs support in AA/trunk, but I didn't change any of the gpio board setup. I also don't have any other atheros boards to try out.

If you're planning on doing more work to clean this up, then sure, go ahead, but in that case, can it all go in together? Does it have to go in part now, and part later?

Cheers,
Karl Palsson

On 11/21/2012 10:29 PM, Jonathan Bither wrote:
Karl,
I remember attitude adjustment not booting as well with flash errors, however I can try to rebuild an older backfire checkout and reflash the device
to log the behavior. The revert was intended to be temporary to fix the
regression with devices not booting. I plan on submitting additional patches that fix the intended behavior. Care to share the model of your device so that I
may get one in to work with?

Thanks,
Jonathan Bither

On 11/21/2012 05:02 PM, Karl P wrote:

I'm still against reverting.  What's really needed here is support for
different atheros devices, not just outright dropping led support. Currently,
the gpio setup is fixed for all devices, which clearly isn't ok.

Sure, I admit that not booting your device is worse than my leds not working, but tossing it all out doesn't really seem like the right way forward. What was the backfire behaviour on your device? Ours had a working wifi light, and the gpio hasn't changed, so I'm surprised that it's only _just_ started being
problems.

Cheers,
Karl P



On 11/21/2012 09:03 PM, Jonathan Bither wrote:
v2: explicitly unset CONFIG_LEDS_GPIO

It causes flash access errors on devices that use a non-standard gpio line line
to control the spi flash chip select. Fixes a handful of open tickets.
First resolved in changeset # 16765

Signed-off-by: Jonathan Bither <jonbit...@gmail.com>
---
target/linux/atheros/base-files/etc/uci-defaults/leds | 11 -----------
  target/linux/atheros/config-3.3                       | 4 ++--
  2 files changed, 2 insertions(+), 13 deletions(-)
delete mode 100644 target/linux/atheros/base-files/etc/uci-defaults/leds

diff --git a/target/linux/atheros/base-files/etc/uci-defaults/leds
b/target/linux/atheros/base-files/etc/uci-defaults/leds
deleted file mode 100644
index 076a04b..0000000
--- a/target/linux/atheros/base-files/etc/uci-defaults/leds
+++ /dev/null
@@ -1,11 +0,0 @@
-#!/bin/sh
-# Copyright 2012 OpenWrt.org
-#
-
-. /lib/functions/uci-defaults.sh
-
-ucidef_set_led_netdev "wlan" "wlan" "wlan" "wlan0"
-
-ucidef_commit_leds
-
-exit 0
diff --git a/target/linux/atheros/config-3.3 b/target/linux/atheros/config-3.3
index 9f68b4e..39d8716 100644
--- a/target/linux/atheros/config-3.3
+++ b/target/linux/atheros/config-3.3
@@ -35,7 +35,7 @@ CONFIG_GENERIC_ATOMIC64=y
  CONFIG_GENERIC_CLOCKEVENTS=y
  CONFIG_GENERIC_CLOCKEVENTS_BUILD=y
  CONFIG_GENERIC_CMOS_UPDATE=y
-CONFIG_GENERIC_GPIO=y
+# CONFIG_GENERIC_GPIO is not set
  CONFIG_GENERIC_IRQ_SHOW=y
  CONFIG_GENERIC_PCI_IOMAP=y
  CONFIG_GPIOLIB=y
@@ -70,7 +70,7 @@ CONFIG_INITRAMFS_SOURCE=""
  CONFIG_IP17XX_PHY=y
  CONFIG_IRQ_CPU=y
  CONFIG_IRQ_FORCED_THREADING=y
-CONFIG_LEDS_GPIO=y
+# CONFIG_LEDS_GPIO is not set
  CONFIG_MDIO_BOARDINFO=y
  CONFIG_MIPS=y
  CONFIG_MIPS_L1_CACHE_SHIFT=5
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to