Jo-Philipp Wich <x...@subsignal.org> [2012-11-26 19:53:52]:

> This can be simplified to:
> 
> is_not_rt2800() {
>       grep -sqE 'Ralink (RT3050|RT3052|RT3350|RT3352)' /proc/cpuinfo
> }

But then it should be changed to is_rt2800(), right?

> Since Daniel Dickinson recently posted a series of patches to override
> the VAP mac generation for a specific product I wonder whether we
> maybe should move the mac generation procedure into an include file...
> something like /lib/platform/mac80211_rules.sh which would provide
> overrides for any functionality that diverges from the default.

Sounds good, there's plan to add this into the AA? I was personally thinking
about such a generalization myself.

> I have no objections to this patch but I wonder whether we should take
> the opportunity to generalize it.

I see this patch as an immediate fix for AA. I don't know, if it's ok to
introduce such a generalization into the AA. It's up to you guys, I'll try to
help as much as I can. Thanks.

-- ynezz
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to