Hi Serge,
thanks for the review and the patience :)
I'll fix that inverted if ... then ... else block and maybe also rename xtal20
in rt2x00_platform_data to be clk_is_20mhz, as that would be more consistent
(ath9k_platform_data which got a clk_is_25mhz flag for a similar purpose).
Cheers
Daniel
On 13/11/12 08:19, Сергей Василюгин wrote:
> Hi
>
> Looks good but something wrong with if-logic (see below)
[...]
>> ++ } else if (rt2x00_rf(rt2x00dev, RF3322)) {
>> ++ spec->num_channels = 14;
>> ++ if (spec->xtal_freq == XTAL_FREQ_20MHZ)
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>> ++ spec->channels = rf_vals_3x;
>> ++ else
>> ++ spec->channels = rf_vals_xtal20mhz_3x;
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> I think you meen == XTAL_FREQ_40MHZ
Yeah, right, I got it exactly the wrong way around :(
Should rather be
if (spec->xtal_freq == XTAL_FREQ_20MHZ)
spec->channels = rf_vals_xtal20mhz_3x;
else
spec->channels = rf_vals_3x;
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
