Hi Florian, On 1 July 2012 19:47, Florian Fainelli <flor...@openwrt.org> wrote: > Hello Ian, > > Le samedi 23 juin 2012 12:29:34, Ian Ridge a écrit : >> Hi, >> >> The patch adds brcm2708 target, plus required mtools and dosfstools to >> the tools directory. It outputs an SD card image suitable for the >> raspberry pi. >> >> Thanks to the people who have sent me feedback. Tool patches seemed >> mangled on V2, so I've sent as combined svn generated patch this time. > > I have a couple comments about your patch: > > - your kernel configuration has too many modules built-in (sound, wireless, > netfilter, HID, crypto). bcm2708 > > - you are missing a target/linux/brcm2708/base-files/etc/inittab override to > set the console to ttyAMA0 (something like target/linux/realview/base- > files/etc/inittab) > > - it seems like the GPU firmware files could be made a as package rather than > a > sub-directory of the image/ directory, event though that's the bootloader > part, uboot is also in package/ >
I was considering if I should also copy the ptgen program or firmware-utils (tools dir) as a package also. The rpi boots off SD card and the SD partition sizes are currently hard coded in the build. As SD cards come in lots of sizes sizes, I was thinking of using utils such as ptgen to repartition and expand to use the entire SD card during firstboot. This solution would allow for minimum image size for distribution and full use of the SD card regardless of size. However ptgen would need to be built for target as well as host, A more simple alternative would be to allow the partition sizes to be configurable in menuconfig. This may not be as helpful to end user though. >> >> I've made the following updates: >> >> Fixed bcm2835 sound driver build for 3.3 kernel. Tested using player >> with an mp3 to HDMI output. >> Cleaned html from 0001-Add-dwc_otg-driver.patch (reducing overall patch >> size) >> >> Need to "chmod a+x target/linux/brcm2708/image/gen_rpi_sdcard_img.sh" > > This is something you can set with either git or svn. > >> >> Works with kernel 3.3 and was tested with openwrt trunk revision 32482 >> (22 June 2012). > > I build tested the patches and they look correct to me. > >> >> Kind Regards >> >> Signed-off-by: Ian Ridge <ianridge at gmail.com> > > -- > Florian Thanks for your comments. I'll make these changes. kind regards Ian _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
