Hello Ian,

Le samedi 23 juin 2012 12:29:34, Ian Ridge a écrit :
> Hi,
> 
> The patch adds brcm2708 target, plus required mtools and dosfstools to
> the tools directory. It outputs an SD card image suitable for the
> raspberry pi.
> 
> Thanks to the people who have sent me feedback. Tool patches seemed
> mangled on V2, so I've sent as combined svn generated patch this time.

I have a couple comments about your patch:

- your kernel configuration has too many modules built-in (sound, wireless, 
netfilter, HID, crypto). bcm2708 

- you are missing a target/linux/brcm2708/base-files/etc/inittab override to 
set the console to ttyAMA0 (something like target/linux/realview/base-
files/etc/inittab)

- it seems like the GPU firmware files could be made a as package rather than a 
sub-directory of the image/ directory, event though that's the bootloader 
part, uboot is also in package/

> 
> I've made the following updates:
> 
>  Fixed bcm2835 sound driver build for 3.3 kernel. Tested using player
> with an mp3 to HDMI output.
>  Cleaned html from 0001-Add-dwc_otg-driver.patch (reducing overall patch
> size)
> 
> Need to "chmod a+x target/linux/brcm2708/image/gen_rpi_sdcard_img.sh"

This is something you can set with either git or svn.

> 
> Works with kernel 3.3 and was tested with openwrt trunk revision 32482
> (22 June 2012).

I build tested the patches and they look correct to me.

> 
> Kind Regards
> 
> Signed-off-by: Ian Ridge <ianridge at gmail.com>

-- 
Florian
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to