Committed revision 24654 On Fri, Dec 17, 2010 at 10:07 AM, Alfred E. Heggestad <a...@db.org> wrote:
> Hi, > > many thanks for committing the patch .. I just noticed that the TABs in > Makefile's > had been converted into space, meaning that the current svn does not build > at the moment .. > > > I have fixed this by converting the spaces back to TAB, and this time the > patch is > attached in the email (i.e. not inline) .. > > > > > > Signed-Off-By: Alfred E. Heggestad <a...@db.org> > > > On 12/17/10 2:31 PM, Outback Dingo wrote: > >> Committed revision 24640 >> >> >> On Wed, Dec 15, 2010 at 5:38 PM, Alfred E. Heggestad <a...@db.org <mailto: >> a...@db.org>> wrote: >> >> On 12/14/10 2:40 AM, Jo-Philipp Wich wrote: >> >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA1 >> >> Hey, >> >> the patch looks clean so far but I don't like the idea of >> conditional >> compilation. For the initial version its okay to always mandate >> libspeex >> etc. and make it a static DEPENDS:=... . >> >> In a later version you should maybe look into providing a "full" >> and >> "mini" variant of your package, or even better, make the code parts >> requiring speex etc. loadable libraries. Of course I cannot judge >> how >> much effort this would be, but maybe consider it. >> >> >> Hi, >> >> thanks for your feedback, I have removed the conditional compilation as >> you >> mentioned, they should not be needed for this initial version ... >> >> >> the applications baresip and restund are already fully modular, and >> each module >> can either be statically linked into the main application, or loaded >> dynamically. >> I think that we can add extra packages later, to extend functionality >> .. >> >> >> >>
_______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
