-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hey,
the patch looks clean so far but I don't like the idea of conditional compilation. For the initial version its okay to always mandate libspeex etc. and make it a static DEPENDS:=... . In a later version you should maybe look into providing a "full" and "mini" variant of your package, or even better, make the code parts requiring speex etc. loadable libraries. Of course I cannot judge how much effort this would be, but maybe consider it. ~ Jow -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk0GyyQACgkQdputYINPTPOlPgCfcpcHQ5g19xklfuZJee2wibLQ 1XUAnioIcW3k395VrgMXtz4EmSTcvVb7 =Q6dK -----END PGP SIGNATURE----- _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
