Inline is better for commenting the patch, as the comment can be placed directly at the discussed location. But a mangled patch is hard to apply.
If it is attached it normally doesn't get mangled, but then commenting is harder as the relevant code is not shown. So if you are sure that the patch is not mangled by your mail client (no wraps, no tabs to spaces), then inline is definitely preferred. Maybe setting some options in your mail client will avoid this behaviour. Maddes On 22.11.2010 08:52, Stefan Tomanek wrote: >> Please attach patches as files next time, since inlining often screws >> them up (in this case spaces <-> tabs). > > Although https://dev.openwrt.org/wiki/SubmittingPatches says otherwise? > > "Send a mail to openwrt-devel <at> lists.openwrt.org with the following > contents: > [...] > 4. Your actual patch, inline, not word wrapped or whitespace mangled. " _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
