Attention is currently required from: flichtenheld, plaisthos. ralf_lici has posted comments on this change by ralf_lici. ( http://gerrit.openvpn.net/c/openvpn/+/739?usp=email )
Change subject: options: add IPv4 CIDR parsing for relevant directives ...................................................................... Patch Set 10: (1 comment) File src/openvpn/options_util.c: http://gerrit.openvpn.net/c/openvpn/+/739/comment/3152c2da_f44cfb55?usp=email : PS9, Line 232: * socket_util.c dependencies into options_util unit-test targets. */ > Okay, to be clear: My opinion is that this code should not be duplicated. […] Done. I used two minimal shared mocks (mock_signal.c, mock_setenv.c) for transitive symbols. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/739?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Iae04ad8715e40dfc76475c2c5b9a766c9604efc9 Gerrit-Change-Number: 739 Gerrit-PatchSet: 10 Gerrit-Owner: ralf_lici <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Tue, 10 Mar 2026 16:18:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <[email protected]> Comment-In-Reply-To: ralf_lici <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
