Attention is currently required from: plaisthos, ralf_lici. flichtenheld has posted comments on this change by ralf_lici. ( http://gerrit.openvpn.net/c/openvpn/+/739?usp=email )
Change subject: options: add IPv4 CIDR parsing for relevant directives ...................................................................... Patch Set 9: (2 comments) File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/739/comment/c0e57a84_9a30f6b2?usp=email : PS9, Line 7688: remote_netmask = getaddr(GETADDR_HOST_ORDER | GETADDR_RESOLVE, ifconfig_push_parms[2], 0, > I agree. The main issue is that IPv4 options in options. […] Acknowledged File src/openvpn/options_util.c: http://gerrit.openvpn.net/c/openvpn/+/739/comment/dc618575_003b428a?usp=email : PS9, Line 232: * socket_util.c dependencies into options_util unit-test targets. */ > Just to make sure I understood this point correctly: do you prefer that I > switch to print_in_addr_t( […] Okay, to be clear: My opinion is that this code should not be duplicated. I think it is complicated enough that we should avoid this. The UT changes are probably not actually a problem. The list of dependencies of test_socket is also reasonably small so I can't imagine this will be a complicated addition to test_options. If that turns out to be wrong we could also look into whether moving the code to options_util would be simpler. There is no strict reason why it needs to be in socket_util. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/739?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Iae04ad8715e40dfc76475c2c5b9a766c9604efc9 Gerrit-Change-Number: 739 Gerrit-PatchSet: 9 Gerrit-Owner: ralf_lici <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: ralf_lici <[email protected]> Gerrit-Comment-Date: Tue, 10 Mar 2026 10:28:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <[email protected]> Comment-In-Reply-To: ralf_lici <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
