Attention is currently required from: MaxF, flichtenheld. plaisthos has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1431?usp=email )
Change subject: Change ssl_ctx in struct tls_options to be a pointer ...................................................................... Patch Set 5: (5 comments) File src/openvpn/init.c: http://gerrit.openvpn.net/c/openvpn/+/1431/comment/503ce1bd_d2891ac8?usp=email : PS4, Line 3129: * SSL context. */ > Please leave `*/` on its own line for consistency Done File src/openvpn/ssl.c: http://gerrit.openvpn.net/c/openvpn/+/1431/comment/e4e71a9c_3b3e27a7?usp=email : PS4, Line 878: all instances sharing the same context > I'm a bit confused here. […] yeah. I tried to word it better. http://gerrit.openvpn.net/c/openvpn/+/1431/comment/ac721aa5_fc4cd00e?usp=email : PS4, Line 878: * all instances sharing the same context > Please add missing ". […] Done File src/openvpn/ssl_common.h: http://gerrit.openvpn.net/c/openvpn/+/1431/comment/42a32659_134db4a7?usp=email : PS4, Line 308: /* our master TLS context from which all SSL objects derived, > "are derived"? Done http://gerrit.openvpn.net/c/openvpn/+/1431/comment/2e35660d_ac9baf46?usp=email : PS4, Line 309: * this context is shared between all instances so point > "points to"? Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1431?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I21251a42f94fa1d9de083d2acd95b887658c5760 Gerrit-Change-Number: 1431 Gerrit-PatchSet: 5 Gerrit-Owner: plaisthos <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-CC: MaxF <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Attention: MaxF <[email protected]> Gerrit-Comment-Date: Mon, 15 Dec 2025 16:06:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <[email protected]> Comment-In-Reply-To: MaxF <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
