Attention is currently required from: plaisthos.

flichtenheld has posted comments on this change by plaisthos. ( 
http://gerrit.openvpn.net/c/openvpn/+/1431?usp=email )

Change subject: Change ssl_ctx in struct tls_options to be a pointer
......................................................................


Patch Set 4: Code-Review-1

(5 comments)

Commit Message:

http://gerrit.openvpn.net/c/openvpn/+/1431/comment/7420438b_56404671?usp=email :
PS4, Line 16: and also the CRL being reload multiple times.
"reloaded"


File src/openvpn/init.c:

http://gerrit.openvpn.net/c/openvpn/+/1431/comment/4b726ecf_b6b6dad8?usp=email :
PS4, Line 3129:          * SSL context. */
Please leave `*/` on its own line for consistency


File src/openvpn/ssl.c:

http://gerrit.openvpn.net/c/openvpn/+/1431/comment/a249f13e_f414aad5?usp=email :
PS4, Line 878:      * all instances sharing the same context
Please add missing "."


File src/openvpn/ssl_common.h:

http://gerrit.openvpn.net/c/openvpn/+/1431/comment/6d9492a9_d331710c?usp=email :
PS4, Line 308:     /* our master TLS context from which all SSL objects derived,
"are derived"?


http://gerrit.openvpn.net/c/openvpn/+/1431/comment/beee4aac_f65ec234?usp=email :
PS4, Line 309:      * this context is shared between all instances so point
"points to"?



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1431?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I21251a42f94fa1d9de083d2acd95b887658c5760
Gerrit-Change-Number: 1431
Gerrit-PatchSet: 4
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Comment-Date: Thu, 11 Dec 2025 12:02:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to