Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1420?usp=email
to review the following change.
Change subject: socket: Initialize struct in_addr_t in getaddr()
......................................................................
socket: Initialize struct in_addr_t in getaddr()
We have false-positive "‘addr’ may be used uninitialized"
warnings with MinGW 13.0.0 compiler. Work around them.
Change-Id: I999916f9561a638214b70cf43de78060e9e0e792
Signed-off-by: Frank Lichtenheld <[email protected]>
---
M src/openvpn/socket.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/20/1420/1
diff --git a/src/openvpn/socket.c b/src/openvpn/socket.c
index 80c2895..3e90833 100644
--- a/src/openvpn/socket.c
+++ b/src/openvpn/socket.c
@@ -202,7 +202,7 @@
getaddr(unsigned int flags, const char *hostname, int resolve_retry_seconds,
bool *succeeded,
struct signal_info *sig_info)
{
- in_addr_t addr;
+ in_addr_t addr = { 0 };
int status;
status = get_addr_generic(AF_INET, flags, hostname, &addr, NULL,
resolve_retry_seconds,
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1420?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I999916f9561a638214b70cf43de78060e9e0e792
Gerrit-Change-Number: 1420
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
