Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1421?usp=email
to review the following change.
Change subject: GHA: Add minGW Release build
......................................................................
GHA: Add minGW Release build
There are sometimes differences in the build results.
Change-Id: I9e1d935f617db9198ed5934b88c0fcdef61a8568
Signed-off-by: Frank Lichtenheld <[email protected]>
---
M .github/workflows/build.yaml
1 file changed, 13 insertions(+), 11 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/21/1421/1
diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index ea45740..ce730f6 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -68,8 +68,9 @@
fail-fast: false
matrix:
arch: [x86, x64]
+ build: [Release, Debug]
- name: "gcc-mingw - ${{ matrix.arch }} - OSSL"
+ name: "gcc-mingw - ${{ matrix.arch }} - ${{matrix.build }} - OSSL"
runs-on: ubuntu-24.04
env:
VCPKG_ROOT: ${{ github.workspace }}/vcpkg
@@ -91,22 +92,22 @@
with:
configurePreset: mingw-${{ matrix.arch }}
buildPreset: mingw-${{ matrix.arch }}
- buildPresetAdditionalArgs: "['--config Debug']"
+ buildPresetAdditionalArgs: "['--config ${{ matrix.build }}']"
- uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4
# v5.0.0
with:
- name: openvpn-mingw-${{ matrix.arch }}
+ name: openvpn-mingw-${{ matrix.arch }}-${{ matrix.build }}
path: |
- ${{ github.workspace }}/out/build/mingw/${{ matrix.arch
}}/**/Debug/*.exe
- ${{ github.workspace }}/out/build/mingw/${{ matrix.arch
}}/**/Debug/*.dll
- !${{ github.workspace }}/out/build/mingw/${{ matrix.arch
}}/Debug/test_*.exe
+ ${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/**/${{
matrix.build }}/*.exe
+ ${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/**/${{
matrix.build }}/*.dll
+ !${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/${{
matrix.build }}/test_*.exe
- uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4
# v5.0.0
with:
- name: openvpn-mingw-${{ matrix.arch }}-tests
+ name: openvpn-mingw-${{ matrix.arch }}-${{ matrix.build }}-tests
path: |
- ${{ github.workspace }}/out/build/mingw/${{ matrix.arch
}}/Debug/test_*.exe
- ${{ github.workspace }}/out/build/mingw/${{ matrix.arch
}}/Debug/*.dll
+ ${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/${{
matrix.build }}/test_*.exe
+ ${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/${{
matrix.build }}/*.dll
mingw-unittest:
needs: [ mingw ]
@@ -115,16 +116,17 @@
matrix:
arch: [x86, x64]
test: [argv, auth_token, buffer, cryptoapi, crypto, misc,
options_parse, ncp, packet_id, pkt, provider, ssl, tls_crypt, user_pass]
+ build: [Release, Debug]
runs-on: windows-2025
- name: "mingw unittest ${{ matrix.test }} - ${{ matrix.arch }} - OSSL"
+ name: "mingw unittest ${{ matrix.test }} - ${{ matrix.arch }} - ${{
matrix.build }} - OSSL"
steps:
- name: Checkout OpenVPN
uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd #
v5.0.1
- name: Retrieve mingw unittest
uses:
actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6.0.0
with:
- name: openvpn-mingw-${{ matrix.arch }}-tests
+ name: openvpn-mingw-${{ matrix.arch }}-${{ matrix.build }}-tests
path: unittests
- name: Run ${{ matrix.test }} unit test
run: ./unittests/test_${{ matrix.test }}.exe
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1421?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I9e1d935f617db9198ed5934b88c0fcdef61a8568
Gerrit-Change-Number: 1421
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
