Attention is currently required from: cron2, plaisthos.

d12fk has posted comments on this change by d12fk. ( 
http://gerrit.openvpn.net/c/openvpn/+/1390?usp=email )

Change subject: iservice: fix calculation of converted domains size
......................................................................


Patch Set 1:

(1 comment)

File src/openvpnserv/interactive.c:

http://gerrit.openvpn.net/c/openvpn/+/1390/comment/4e90d085_1e83014a?usp=email :
PS1, Line 2207:                 domain_size += 1;
> shouldn't that be `+= one_glyph` here?  A wide-character dot will still take 
> 2 bytes? […]
Good catch! Moved it up there in prep for a following patch, adding one_glyph 
is the way to go.



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1390?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I16f9426e57f4802ba038ab51f5b70161464b9428
Gerrit-Change-Number: 1390
Gerrit-PatchSet: 1
Gerrit-Owner: d12fk <[email protected]>
Gerrit-Reviewer: cron2 <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: cron2 <[email protected]>
Gerrit-Comment-Date: Sun, 23 Nov 2025 19:47:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2 <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to