Attention is currently required from: d12fk, plaisthos. cron2 has posted comments on this change by d12fk. ( http://gerrit.openvpn.net/c/openvpn/+/1390?usp=email )
Change subject: iservice: fix calculation of converted domains size ...................................................................... Patch Set 1: Code-Review-1 (2 comments) Patchset: PS1: I might be misreading this, but I think there is still an char/wchar mixup here File src/openvpnserv/interactive.c: http://gerrit.openvpn.net/c/openvpn/+/1390/comment/d13a1328_0f71fd2d?usp=email : PS1, Line 2207: domain_size += 1; shouldn't that be `+= one_glyph` here? A wide-character dot will still take 2 bytes? Maybe just move the `size_t domain_size = domain_len * one_glyph` down here so it will get the +1 right away? (Also it feels a bit more logical to do this after the ListContainsDomain() block, where it is used) -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1390?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I16f9426e57f4802ba038ab51f5b70161464b9428 Gerrit-Change-Number: 1390 Gerrit-PatchSet: 1 Gerrit-Owner: d12fk <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: d12fk <[email protected]> Gerrit-Comment-Date: Sun, 23 Nov 2025 11:48:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
