I have stared-at-code for a while (looks reasonable), subjected to the
client/server testbed (which does not actually *do* PUSH_UPDATE yet, still),
and ran a few manual tests. This all works as it did before - did not
try to find new and interesting edge cases. (I did *not* actively try, but
still found #889...)
We might eventually clean up the repeated
{
+ buffer_list_free(msgs);
gc_free(&gc);
return 1;
}
clauses into a common "cleanup:" clause... but this is also not important
right now. We should refrain from adding even more cleanups there, though ;-)
The extra unit tests are very welcome.
Your patch has been applied to the master branch.
commit 6b0208e962aadf285ecc7ab47cc973a9018e3f24
Author: Marco Baffo
Date: Thu Oct 30 20:52:35 2025 +0100
PUSH_UPDATE server: invalid read bug-fix and unit-tests improvements
Signed-off-by: Marco Baffo <[email protected]>
Acked-by: Gert Doering <[email protected]>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1316
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg34073.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
