Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1334?usp=email
to review the following change.
Change subject: Add -lpathcch for mingw32 builds using autotools
......................................................................
Add -lpathcch for mingw32 builds using autotools
This was missed in commit 05a8ba8
Note: the check for PATHCCH_ENSURE_TRAILING_SLASH in
configure.ac may be omitted if we build only using latest
mingw32-w64 toolchain. Ubuntu 24.04 is not new enough.
Change-Id: Ifea896e722635a471cc01f930bc1e5d0f2c165be
Signed-off-by: Selva Nair <[email protected]>
---
M configure.ac
M src/openvpnserv/Makefile.am
2 files changed, 12 insertions(+), 1 deletion(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/34/1334/1
diff --git a/configure.ac b/configure.ac
index 8f3c01d..3117e13 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1383,6 +1383,17 @@
fi
fi
+if test "${WIN32}" == "yes"; then
+ AC_CHECK_DECLS(
+ [PATHCCH_ENSURE_TRAILING_SLASH],
+ [AC_DEFINE([HAVE_PATHCCH_ENSURE_TRAILING_SLASH], [1],
[PATHCCH_ENSURE_TRAILING_SLASH is defined])],
+ ,
+ [[
+ #include <pathcch.h>
+ ]]
+ )
+fi
+
# When testing a compiler option, we add -Werror to force
# an error when the option is unsupported. This is not
# required for gcc, but some compilers such as clang need it.
diff --git a/src/openvpnserv/Makefile.am b/src/openvpnserv/Makefile.am
index a27fbbf..f45d770 100644
--- a/src/openvpnserv/Makefile.am
+++ b/src/openvpnserv/Makefile.am
@@ -27,7 +27,7 @@
-D_WIN32_WINNT=_WIN32_WINNT_VISTA
openvpnserv_LDADD = \
-ladvapi32 -luserenv -liphlpapi -lfwpuclnt -lrpcrt4 \
- -lshlwapi -lnetapi32 -lws2_32 -lntdll -lole32
+ -lshlwapi -lnetapi32 -lws2_32 -lntdll -lole32 -lpathcch
noinst_DATA = \
MSG00409.bin eventmsg.h eventmsg.rc openvpnservmsg.dll
BUILT_SOURCES = \
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1334?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ifea896e722635a471cc01f930bc1e5d0f2c165be
Gerrit-Change-Number: 1334
Gerrit-PatchSet: 1
Gerrit-Owner: selvanair <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
