Attention is currently required from: d12fk, flichtenheld, plaisthos.

stipa has posted comments on this change by d12fk. ( 
http://gerrit.openvpn.net/c/openvpn/+/1308?usp=email )

Change subject: iservice: use interface index with netsh
......................................................................


Patch Set 2: Code-Review-2

(1 comment)

File src/openvpnserv/interactive.c:

http://gerrit.openvpn.net/c/openvpn/+/1308/comment/08e6deb9_153f7b37?usp=email :
PS2, Line 2910:         free(RemoveListItem(&(*lists)[undo_wins], CmpAny, 
NULL));
Since we removed the only invocation of CmpWString, clang complains that

C:\Users\lev\Projects\openvpn-build\src\openvpn\src\openvpnserv\interactive.c(1055,1):
 error : unused function 'CmpWString' [-Werror,-Wunused-function] 
[C:\Users\lev\Projects\openvpn-build\src\openvpn\out\build\win-amd64-clang-debug\src\openvpnserv\openvpnserv.vcxproj]



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1308?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I329b407693b97dd048bd3788ecad345d6e25dab2
Gerrit-Change-Number: 1308
Gerrit-PatchSet: 2
Gerrit-Owner: d12fk <[email protected]>
Gerrit-Reviewer: cron2 <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-Reviewer: stipa <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Attention: d12fk <[email protected]>
Gerrit-Comment-Date: Thu, 30 Oct 2025 07:40:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to