Attention is currently required from: d12fk, flichtenheld, plaisthos.

cron2 has posted comments on this change by d12fk. ( 
http://gerrit.openvpn.net/c/openvpn/+/1308?usp=email )

Change subject: iservice: use interface index with netsh
......................................................................


Patch Set 1: Code-Review-2

(1 comment)

Patchset:

PS1:
This fails the integer checks on a windows build

```
oC:\Buildbot\windows-server-2025-latent-ec2-msbuild-x86-clang\build\src\openvpnserv\interactive.c(3197,47):
 error : incompatible pointer to integer conversion passing 'LPVOID' (aka 'void 
*') to parameter of type 'int' [-Wint-conversion] 
[C:\Buildbot\windows-server-2025-latent-ec2-msbuild-x86-clang\build\out\build\win-x86-clang-release\src\openvpnserv\openvpnserv.vcxproj]
o  
C:\Buildbot\windows-server-2025-latent-ec2-msbuild-x86-clang\build\src\openvpnserv\interactive.c(1007,43):
 note: passing argument to parameter 'if_index' here
```



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1308?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I329b407693b97dd048bd3788ecad345d6e25dab2
Gerrit-Change-Number: 1308
Gerrit-PatchSet: 1
Gerrit-Owner: d12fk <[email protected]>
Gerrit-Reviewer: cron2 <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Attention: d12fk <[email protected]>
Gerrit-Comment-Date: Tue, 28 Oct 2025 19:28:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to