Attention is currently required from: flichtenheld, plaisthos.
cron2 has posted comments on this change by plaisthos. (
http://gerrit.openvpn.net/c/openvpn/+/1321?usp=email )
Change subject: Fix logic when pushed cipher triggers tun reopen and ignore
more options
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
> welcome to openvpn logic. link-mtu and tun-mtu are mutally exclusive. […]
Right, this is why the code should check for `link_mtu_defined` and not
`tun_mtu_defined`. Right? `if (cipher && !link_mtu_defined) { skip this }`.
But you're right, I misread this - `tun_mtu_defined` implies
`!link_mtu_defined`, so while I find the other one easier to follow ("if
link_mtu defined, tun_mtu is derived from cipher etc.") the code is correct.
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1321?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I76eb584024610a6054a069340adbac988abf686c
Gerrit-Change-Number: 1321
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: cron2 <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Wed, 29 Oct 2025 06:52:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: plaisthos <[email protected]>
Comment-In-Reply-To: cron2 <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
