Attention is currently required from: cron2, flichtenheld. plaisthos has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1321?usp=email )
Change subject: Fix logic when pushed cipher triggers tun reopen and ignore more options ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: > I don't think the logic is right now (neither before nor afterwards). […] welcome to openvpn logic. link-mtu and tun-mtu are mutally exclusive. And you need to have link-mtu in the config to actually have a pushed cipher to change the MTU of the tun device. File src/openvpn/push.c: http://gerrit.openvpn.net/c/openvpn/+/1321/comment/036771c8_d363c718?usp=email : PS1, Line 1046: if (strprefix(line, "cipher ") && opt->ce.tun_mtu_defined) > I don't think this is actually correct - `--tun-mtu` is the *inner* MTU, and > that never changes on ` […] The question is more if we want to deprecate link-mtu and its weird behaviour. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1321?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I76eb584024610a6054a069340adbac988abf686c Gerrit-Change-Number: 1321 Gerrit-PatchSet: 1 Gerrit-Owner: plaisthos <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: cron2 <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Tue, 28 Oct 2025 22:47:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
