Attention is currently required from: flichtenheld.

plaisthos has posted comments on this change by plaisthos. ( 
http://gerrit.openvpn.net/c/openvpn/+/1288?usp=email )

Change subject: Warn if push is used without --mode 
server/--server/--server-bridge
......................................................................


Patch Set 1:

(4 comments)

Commit Message:

http://gerrit.openvpn.net/c/openvpn/+/1288/comment/d7f5c5d0_97f445f3?usp=email :
PS1, Line 14: Also remove an used macro.
> "unused" I assume
Acknowledged


File src/openvpn/options.c:

http://gerrit.openvpn.net/c/openvpn/+/1288/comment/9676fd5c_46a87c6f?usp=email :
PS1, Line 3337:   
> whitespace
Done


http://gerrit.openvpn.net/c/openvpn/+/1288/comment/04ba28cd_b064d58d?usp=email :
PS1, Line 3338:     if (o->push_list.head && o->mode != MODE_SERVER)
> We have a lot of warnings and errors that we potentially throw if not in 
> --mode server, see code aro […]
Done


http://gerrit.openvpn.net/c/openvpn/+/1288/comment/861ffac4_9f1909cd?usp=email :
PS1, Line 3340:         msg(M_WARN, "Note: Using --push without --mode server 
is an unsupported"
> We probably also should add a note under --push in the documentation.
Done



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1288?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I82c7c61be07593ecd5bf2f854767dda74ab5170c
Gerrit-Change-Number: 1288
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Mon, 20 Oct 2025 16:16:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to