Attention is currently required from: plaisthos. flichtenheld has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1288?usp=email )
Change subject: Warn if push is used without --mode server/--server/--server-bridge ...................................................................... Patch Set 1: Code-Review-1 (4 comments) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/1288/comment/f7cedb8d_5f290a51?usp=email : PS1, Line 14: Also remove an used macro. "unused" I assume File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/1288/comment/d6b588cf_299e97fa?usp=email : PS1, Line 3337: whitespace http://gerrit.openvpn.net/c/openvpn/+/1288/comment/bf2317ec_7c3577ee?usp=email : PS1, Line 3338: if (o->push_list.head && o->mode != MODE_SERVER) We have a lot of warnings and errors that we potentially throw if not in --mode server, see code around line 2650. Maybe this new check would be better put there? http://gerrit.openvpn.net/c/openvpn/+/1288/comment/1d984d7c_11af20d7?usp=email : PS1, Line 3340: msg(M_WARN, "Note: Using --push without --mode server is an unsupported" We probably also should add a note under --push in the documentation. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1288?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I82c7c61be07593ecd5bf2f854767dda74ab5170c Gerrit-Change-Number: 1288 Gerrit-PatchSet: 1 Gerrit-Owner: plaisthos <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Comment-Date: Mon, 20 Oct 2025 14:57:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
