Attention is currently required from: MaxF, flichtenheld, plaisthos. cron2 has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1153?usp=email )
Change subject: options: Review use of positive_atoi vs atoi_constrained ...................................................................... Patch Set 6: Code-Review+2 (1 comment) File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/1153/comment/18e489ea_91e53016?usp=email : PS5, Line 7997: atoi_constrained(p[1], &options->max_routes_per_client, p[0], 1, INT_MAX, msglevel); > This changes the program behavior. […] I think this is acceptable. There might be a config somewhere that has `max-routes-per-client 0` in it, auto-upgraded to `1`, but it does not make any sense whatsoever... "do not use options you do not understand". -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1153?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Id440917f433aab1a7db608ba04fa95ba47c2ddde Gerrit-Change-Number: 1153 Gerrit-PatchSet: 6 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: MaxF <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Attention: MaxF <[email protected]> Gerrit-Comment-Date: Thu, 09 Oct 2025 20:59:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: MaxF <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
