Attention is currently required from: flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1153?usp=email )
Change subject: options: Review use of positive_atoi vs atoi_constrained ...................................................................... Patch Set 5: Code-Review+1 (1 comment) File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/1153/comment/b09f5803_fa7ecbdd : PS5, Line 7997: atoi_constrained(p[1], &options->max_routes_per_client, p[0], 1, INT_MAX, msglevel); This changes the program behavior. Before, it silently corrected max_routes_per_client to 1, now it exits with an error. Probably a good change, but I'm not sure if you intended this commit to change behavior. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1153?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Id440917f433aab1a7db608ba04fa95ba47c2ddde Gerrit-Change-Number: 1153 Gerrit-PatchSet: 5 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: MaxF <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Fri, 26 Sep 2025 17:08:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
