Attention is currently required from: cron2, flichtenheld, plaisthos.
Hello cron2, flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/890?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review-1 by cron2
Change subject: Always use a 0.0.0.0/0 default on Android instead of def1
......................................................................
Always use a 0.0.0.0/0 default on Android instead of def1
Certain handset manufactures (like Samsung iirc) are handling
0.0.0.0/0 different from the split /1 routes, so push the 0.0.0.0/0
route to the OS.
Change-Id: I22e4b73e744c765a43bdb29f6e18813d103ea757
Signed-off-by: Arne Schwabe <a...@rfc2549.org>
---
M src/openvpn/options.c
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/90/890/2
diff --git a/src/openvpn/options.c b/src/openvpn/options.c
index 31000e9..19cf455 100644
--- a/src/openvpn/options.c
+++ b/src/openvpn/options.c
@@ -7320,7 +7320,10 @@
}
else if (streq(p[j], "def1"))
{
+#ifndef TARGET_ANDROID
+ /* Android always uses 0.0.0.0/0, so silently ignore the flag
*/
options->routes->flags |= RG_DEF1;
+#endif
}
else if (streq(p[j], "bypass-dhcp"))
{
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/890?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I22e4b73e744c765a43bdb29f6e18813d103ea757
Gerrit-Change-Number: 890
Gerrit-PatchSet: 2
Gerrit-Owner: plaisthos <arne-open...@rfc2549.org>
Gerrit-Reviewer: cron2 <g...@greenie.muc.de>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: cron2 <g...@greenie.muc.de>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-MessageType: newpatchset
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
