Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/801?usp=email )
Change subject: Change API of init_key_ctx to use struct key_paramters ...................................................................... Patch Set 8: Code-Review-1 (7 comments) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/801/comment/d5dc012d_2cbbcd2a : PS8, Line 7: Change API of init_key_ctx to use struct key_paramters key_parameters http://gerrit.openvpn.net/c/openvpn/+/801/comment/4aa5e0d0_d728fca3 : PS8, Line 9: This introduces a new structure key_paramters. The reason is that the key_parameters Patchset: PS8: Typos and nitpicks File src/openvpn/crypto.h: http://gerrit.openvpn.net/c/openvpn/+/801/comment/475bd1eb_01333a7a : PS8, Line 176: * Converts a struct key representation into a struct key_params representation. key_parameters File tests/unit_tests/openvpn/test_auth_token.c: http://gerrit.openvpn.net/c/openvpn/+/801/comment/aaed804b_181e091c : PS8, Line 91: key.hmac_size = 64; /* 64 byte of 0 */ Use `MAX_HMAC_KEY_LENGTH` instead? File tests/unit_tests/openvpn/test_tls_crypt.c: http://gerrit.openvpn.net/c/openvpn/+/801/comment/491ee4f7_038e96a7 : PS8, Line 160: struct key_parameters key = { .cipher = { 0 }, .hmac = { 0 }, .hmac_size = 64, .cipher_size = 64 }; Use `MAX_HMAC_KEY_LENGTH` and `MAX_CIPHER_KEY_LENGTH` instead? http://gerrit.openvpn.net/c/openvpn/+/801/comment/09708593_0ee44299 : PS8, Line 370: struct key_parameters key = { .cipher = { 1 }, .hmac = { 1 }, .cipher_size = 64, .hmac_size = 64 }; Use `MAX_HMAC_KEY_LENGTH` and `MAX_CIPHER_KEY_LENGTH` instead? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/801?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I4a981c5a70717e2276d89bf83a06c7fdbe6712d7 Gerrit-Change-Number: 801 Gerrit-PatchSet: 8 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Comment-Date: Mon, 23 Dec 2024 11:39:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
