Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/801?usp=email )
Change subject: Change API of init_key_ctx to use struct key_paramters ...................................................................... Patch Set 5: Code-Review-2 (5 comments) File src/openvpn/crypto.h: http://gerrit.openvpn.net/c/openvpn/+/801/comment/5982a4b7_c94afe48 : PS5, Line 158: /** internal structure similar to struct key that hold key information "holds" File src/openvpn/crypto.c: http://gerrit.openvpn.net/c/openvpn/+/801/comment/c483a455_001f6aab : PS5, Line 902: , Needs update http://gerrit.openvpn.net/c/openvpn/+/801/comment/59b2558f_a402ae56 : PS5, Line 915: impl_iv_len Change to `ASSERT(impl_iv_len <= key->hmac_size);` to keep consistency http://gerrit.openvpn.net/c/openvpn/+/801/comment/9992be96_25c470fb : PS5, Line 1128: key_params->cipher_size = MAX_HMAC_KEY_LENGTH; `MAX_CIPHER_KEY_LENGTH` http://gerrit.openvpn.net/c/openvpn/+/801/comment/b7fb9ae2_fc643aa9 : PS5, Line 1129: MAX_CIPHER_KEY_LENGTH `MAX_HMAC_KEY_LENGTH` -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/801?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I4a981c5a70717e2276d89bf83a06c7fdbe6712d7 Gerrit-Change-Number: 801 Gerrit-PatchSet: 5 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Comment-Date: Fri, 29 Nov 2024 16:59:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
