Attention is currently required from: flichtenheld, ordex, plaisthos. its_Giaan has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/758?usp=email )
Change subject: pass link_socket object to i/o functions ...................................................................... Patch Set 3: (3 comments) File src/openvpn/forward.h: http://gerrit.openvpn.net/c/openvpn/+/758/comment/4d6847aa_849cf9a1 : PS2, Line 134: * @param ls The socket where the packet can be read from. > forgot to update param name Done http://gerrit.openvpn.net/c/openvpn/+/758/comment/c87bde40_f1f05657 : PS2, Line 204: * @param ls The socket to be used to send the packet. > param name Done File src/openvpn/mudp.c: http://gerrit.openvpn.net/c/openvpn/+/758/comment/9f4e3954_3e858ca1 : PS2, Line 320: process_outgoing_link(&m->top, &m->top.c2.link_socket[0]); > Why this weird syntax here? Isn't that equivalent to "m->top.c2. […] Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/758?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I8eae2d3356bbcc5d632eeb4fbe80de8009d9b40d Gerrit-Change-Number: 758 Gerrit-PatchSet: 3 Gerrit-Owner: its_Giaan <gianma...@mandelbit.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: ordex <a...@unstable.cc> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: ordex <a...@unstable.cc> Gerrit-Comment-Date: Wed, 09 Oct 2024 08:15:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
