Attention is currently required from: flichtenheld, its_Giaan, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/758?usp=email )
Change subject: pass link_socket object to i/o functions ...................................................................... Patch Set 1: (1 comment) File src/openvpn/forward.c: http://gerrit.openvpn.net/c/openvpn/+/758/comment/b7acdcf0_2ef7ae9c : PS1, Line 928: read_incoming_link(struct context *c, struct link_socket *ls) > Why not use "link_socket" as the variable name? No need to be cryptic. […] Because calls from line 950 and below becomes messy due to line length 😄 So "ls" seems a reasonable compromise. socket.c:969:link_socket_update_flags() and socket.c:983:link_socket_update_buffer_sizes() also use "ls" Otherwise all other functions call it "sock". Any preference? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/758?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I8eae2d3356bbcc5d632eeb4fbe80de8009d9b40d Gerrit-Change-Number: 758 Gerrit-PatchSet: 1 Gerrit-Owner: its_Giaan <gianma...@mandelbit.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: ordex <a...@unstable.cc> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: its_Giaan <gianma...@mandelbit.com> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Wed, 25 Sep 2024 11:54:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
