Attention is currently required from: flichtenheld, its_Giaan, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/759?usp=email )
Change subject: io_work: convert shift argument to uintptr_t ...................................................................... Patch Set 1: (3 comments) File src/openvpn/forward.c: http://gerrit.openvpn.net/c/openvpn/+/759/comment/b8b190fc_6d65f800 : PS1, Line 2054: static uintptr_t socket_shift = 0; /* depends on SOCKET_READ and SOCKET_WRITE */ > Why the replacement of the macros here? I think this patch predates the introduction of those macros. So this assignments need to be changed. http://gerrit.openvpn.net/c/openvpn/+/759/comment/e513c4d7_f82f90ad : PS1, Line 2171: > Probably need to change here as well? This patch does not work, but the > followup patch does. […] the & should not be there. http://gerrit.openvpn.net/c/openvpn/+/759/comment/b177699b_21cb28af : PS1, Line 2176: dco_shift > Miss here as well? the & should not be there -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/759?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ib583bf17e35b14aed78fd8217b6e71e8c2b78089 Gerrit-Change-Number: 759 Gerrit-PatchSet: 1 Gerrit-Owner: its_Giaan <gianma...@mandelbit.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: ordex <a...@unstable.cc> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: its_Giaan <gianma...@mandelbit.com> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Wed, 25 Sep 2024 12:00:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
