Attention is currently required from: its_Giaan, ordex, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/759?usp=email )
Change subject: io_work: convert shift argument to uintptr_t ...................................................................... Patch Set 1: Code-Review-2 (4 comments) Patchset: PS1: This patch does not pass the tests File src/openvpn/forward.c: http://gerrit.openvpn.net/c/openvpn/+/759/comment/fd14f418_905c5966 : PS1, Line 2054: static uintptr_t socket_shift = 0; /* depends on SOCKET_READ and SOCKET_WRITE */ Why the replacement of the macros here? http://gerrit.openvpn.net/c/openvpn/+/759/comment/87af5a06_5a0e69af : PS1, Line 2171: Probably need to change here as well? This patch does not work, but the followup patch does. I assume it is because you forgot to change this here since you change it to something else in the followup patch. http://gerrit.openvpn.net/c/openvpn/+/759/comment/9d5f598a_d521d386 : PS1, Line 2176: dco_shift Miss here as well? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/759?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ib583bf17e35b14aed78fd8217b6e71e8c2b78089 Gerrit-Change-Number: 759 Gerrit-PatchSet: 1 Gerrit-Owner: its_Giaan <gianma...@mandelbit.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: ordex <a...@unstable.cc> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: its_Giaan <gianma...@mandelbit.com> Gerrit-Attention: ordex <a...@unstable.cc> Gerrit-Comment-Date: Wed, 25 Sep 2024 11:34:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
