Attention is currently required from: flichtenheld, ordex, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/769?usp=email )
Change subject: dco: better naming for function parameters ...................................................................... Patch Set 3: (2 comments) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/769/comment/ef01a97d_ed0135c4 : PS2, Line 10: those are in fact VPN IPv4/v4 addresses and not > IPv4/v6 maybe? Acknowledged File src/openvpn/dco_freebsd.c: http://gerrit.openvpn.net/c/openvpn/+/769/comment/6574c7f7_14168c34 : PS2, Line 78: struct in_addr *vpn_in4, struct in6_addr *vpn_in6) > should we go with vpn_ipv4 and vpn_ipv6? in4/in6 doesn't mean much as this is > not about sockaddrs. Acknowledged -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/769?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I101bbc9f682375ec733bca10b52da82f0abfec27 Gerrit-Change-Number: 769 Gerrit-PatchSet: 3 Gerrit-Owner: stipa <lstipa...@gmail.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: ordex <a...@unstable.cc> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: ordex <a...@unstable.cc> Gerrit-Comment-Date: Wed, 25 Sep 2024 08:07:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: ordex <a...@unstable.cc> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
