Attention is currently required from: flichtenheld, plaisthos, stipa. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/769?usp=email )
Change subject: dco: better naming for function parameters ...................................................................... Patch Set 2: Code-Review-1 (2 comments) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/769/comment/706e7ad5_af24c1dc : PS2, Line 10: those are in fact VPN IPv4/v4 addresses and not IPv4/v6 maybe? File src/openvpn/dco_freebsd.c: http://gerrit.openvpn.net/c/openvpn/+/769/comment/8770a529_eeb6195c : PS2, Line 78: struct in_addr *vpn_in4, struct in6_addr *vpn_in6) should we go with vpn_ipv4 and vpn_ipv6? in4/in6 doesn't mean much as this is not about sockaddrs. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/769?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I101bbc9f682375ec733bca10b52da82f0abfec27 Gerrit-Change-Number: 769 Gerrit-PatchSet: 2 Gerrit-Owner: stipa <lstipa...@gmail.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: ordex <a...@unstable.cc> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: stipa <lstipa...@gmail.com> Gerrit-Comment-Date: Wed, 25 Sep 2024 07:30:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
