Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/738?usp=email )
Change subject: Move to common backend_driver type in struct tuntap ...................................................................... Patch Set 7: (2 comments) File src/openvpn/tun.h: http://gerrit.openvpn.net/c/openvpn/+/738/comment/2be53bb0_c2ced10a : PS5, Line 46: #ifdef WIN32 > Do we really need pre-processor here? Doesn't hurt if the enum contains > unused values, does it? It is different philosophies. One could argue that you catch a windows only define used out of windows only code. The other is that too many define/ifdefs are worse. File src/openvpn/tun.c: http://gerrit.openvpn.net/c/openvpn/+/738/comment/369450ea_d033a0b6 : PS5, Line 63: #ifdef WIN32 > Again, don't think we really need the #ifdefs here... DO you propose to have them always be defined? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/738?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I8c0e9f32b235cb262ca2be6aac8d520e49b30d74 Gerrit-Change-Number: 738 Gerrit-PatchSet: 7 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Tue, 17 Sep 2024 16:48:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
